✨ Adds a patch to configure ServiceMonitor with to ensure TLS verification using cert-manager certificates #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
from
a9d1f34
to
5372f6a
Compare
|
c/c @fgiloux |
camilamacedo86
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
from
5372f6a
to
23b1f03
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
4 times, most recently
from
3da5ce7
to
170d528
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
camilamacedo86
changed the title
k8s-ci-robot
added
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
from
170d528
to
f8ba05c
Compare
k8s-ci-robot
added
size/L
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
from
b7a8068
to
e7c1cd0
Compare
…t-manager-managed serving-cert with TLS verification Adds a patch to configure ServiceMonitor with `insecureSkipVerify: false` to ensure TLS verification using cert-manager certificates. Updates documentation and corrects misaligned comments.
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
2 times, most recently
from
f8ba05c
to
3b9808e
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/hold Just to not merge before we do a patch release; #4284 |
k8s-ci-robot
added
the
do-not-merge/hold
|
Hi @fgiloux Your request is done here. |
camilamacedo86
force-pushed
the
patch-cert-mamager-service-monitor
branch
from
3b9808e
to
b7a8068
Compare
fgiloux
approved these changes
Nov 4, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, fgiloux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a patch to configure ServiceMonitor with to ensure TLS verification using cert-manager certificates. Updates documentation and corrects misaligned comments.
Motivation: #3657
Closes (Phase-2): #3871